grandizzy

Results 349 comments of grandizzy

@Reiss-Cashmore is that still an issue with latest nightly and macOS (M1)? Thank you

this should be solved now with https://github.com/foundry-rs/foundry/pull/8412, please retest and reopen if still an issue. thank you

@0xPhaze the `testFun` behavior is inline now using latest build, showing proper failure ```bash Encountered 1 failing test in test/Counter.t.sol:CounterTest [FAIL: assertion failed: 1 != 2] testFun() (gas: 3070) ```...

optimistically close this per comment above, @0xPhaze please reopen if still an issue. thank you!

adding it in 1.0 to be discussed ref https://twitter.com/msolomon44/status/1859021021984289220

> I think there's two things here that would be useful: > > 1. Below a trace, showing the decoded state diffs for the full transaction. For forge test it'd...

@sakulstra @mds1 please share your thoughts re proposed cheatcode and output here https://github.com/foundry-rs/foundry/pull/9435 thank you!

> The problem with using `vm.expectRevert` before an internall call is that, if the internal call does not revert, execution will continue and silently consume the next revert, which was...

> My feeling is that there should be at least two separate assertions for what this cheatcode does: (1) expect the next external call to revert, and (2) expect the...

@mds1 thank you, I agree this is not intuitive and dangerous as one would expect to continue execution. What happens is that in case of a successful expectRevert we just...