grandizzy

Results 349 comments of grandizzy

considering there is no practical solution, going to mark as resolved with updated docs PR https://github.com/foundry-rs/foundry/pull/8369 Please reopen if disagree. thank you!

> @grandizzy @klkvr for your thoughts on this :) sorry for late reply. this will be a great improvement, but IMO at this point we cannot really rely on coverage...

going to track implementation with symbolic execution https://github.com/foundry-rs/foundry/issues/15

going to add this built on top of https://github.com/paradigmxyz/revm-inspectors/pull/255

> Noticing a bit of flakyness with invariant tests recently in the CI, for example see: https://github.com/foundry-rs/foundry/actions/runs/10298801797/job/28504775878 / https://github.com/foundry-rs/foundry/actions/runs/10286582825/job/28467603861 > > cc @grandizzy yep, this should make it faster and...

@mattsse I actually think there's a bug introduced with https://github.com/foundry-rs/foundry/pull/8497 here, as it seems the executor for fuzz tests is not cloned anymore? https://github.com/foundry-rs/foundry/commit/4a41367398ddc35faf705f5d93e7e1a4eae3884d#diff-98c09a5d1cb595f37109d7b1c0109ee32dd74dc1d253cdda9a63e4ce32bf49d5R628-R671 Le: actually `Cow::Borrowed().into_owned()` is cloning it,...

thanks for your PR! Generally this is recommended https://github.com/foundry-rs/foundry/issues/8449 but will consider making it automatically (I think we want this only if fuzzed function is payable)

@michprev could you please check if that's the same with latest anvil? This area of code was changed (migrated to alloy providers) and errors should be properly set in TransactionTrace.error...

I confirm this is no longer an issue, error field is set if tx reverted, e.g. for linea failed tx https://lineascan.build/tx/0x314bac8fe99200e5e0c928d9dd399091bb69ae774835272cb5d524d3711a9176 the error filed is populated as `"error":"Reverted"` ```bash curl...

same as https://github.com/foundry-rs/foundry/issues/1573, going to close it as dupe and track it there. thank you