Renée

Results 465 comments of Renée

> Maybe a better approach is to forget about non-blocking IO on macOS as well as Windows? I think that makes sense

@sushant3524 Accepting invalid queries in the router may cause all kind of unsupported glitches in the router and in the query planner. The router does not do validation in JS...

Iiinteresting! This would probably be fixed by #4551 since validation will happen before we modify the operation. But, it means that we have invalid operations floating around in the router,...

yeah, tests in the other PR look satisfactory to me, so no need to add this

@Filirom1 Hi, would you mind merging this? If you don't have time to work on this module I'd be happy to do a new release too! I'd love to see...

Published this as a fork at [@choojs/findup](https://npmjs.com/package/@choojs/findup) in the mean time.

> This does mean that there are a number modules that specify "browser": "browser.js" which would be invalid. i don't have numbers on this but i've definitely seen it in...

@pemrouz if you're still interested in working on this i can review later this week. no guarantees that defunctzombie will have time in the near future to do merges/releases ofc...

Thanks for the report! As the readme says we don't encourage people to use static-eval on untrusted input because of things like this, there are probably many more undiscovered ways...

i'll have a look at this tomorrow. the big change in v3 was that unknown uses of a module are now kept, instead of removed (risking runtime errors). but v3...