Renée
Renée
Need to merge & release https://github.com/nearform/node-clinic-common/pull/21 then we can get this in :) (and the PRs on the other repos)
This dropdown is super cool. My first thoughts from playing with this are similar; the outline can be hard to see so a light background similar to what the search...
So 0x has [this file](https://github.com/davidmarkclements/0x/blob/ea239f31379922451456518479bf442499426853/lib/v8-log-to-ticks.js) that turns a v8 profiler log into an array of stack traces called `ticks`. Each element in the array is the stack trace at a...
Tests fail locally for me with `--collectDelay is not a recognised flag`. CI installs 0x from npm and the version published on npm doesn't include that flag yet. Normally we...
@DylanC that's actually expected output from a test that tests a failure case … would be good to silence that somehow :sweat_smile: Failures can be a bit obscured on CI...
hmm yeah i'm looking at it too…seems like allsome of the other ones are still seeing the `delayOneSecond` node :/ there are two `.DS_Store` files in this PR still. could...
Some of the other tests became(?) flaky? Working on that in https://github.com/nearform/node-clinic-flame/pull/108
We can add the necessary systemInfo data to the `dataFile` value here: https://github.com/nearform/node-clinic-doctor/blob/0d5e9aabec6356b4051b59a7571e1aad10ea7a87/index.js#L205-L211 which will make it available in this callback in the visualizer: https://github.com/nearform/node-clinic-doctor/blob/0d5e9aabec6356b4051b59a7571e1aad10ea7a87/visualizer/main.js#L90
It looks like `TryInto` support is still waiting for a new release of the `url` crate.
Doc comment lines are wrapped in a `` on docs.rs. Looks like the HTML contains a `\r` _before_ the closing ``, and `\n` _between_ spans. Maybe an issue with crates...