findup
findup copied to clipboard
remove colors dependency
Findup's dependency on colors annoys me for a small tool which doesn't greatly benefit from the colorized output. Also the colors package injects into the String.prototype, which I don't find particularly attractive.
Your thoughts?
@Filirom1 Hi, would you mind merging this? If you don't have time to work on this module I'd be happy to do a new release too!
I'd love to see this merged; the colors
dependency is causing a pretty significant slowdown (300ms) in bankai, because it adds expensive getters to the string prototype, and a CSS parser module in our dependency tree sometimes does for (var i in stringValue) {}
causing every getter to be called.
Published this as a fork at @choojs/findup in the mean time.
@goto-bus-stop this might be useful for you, especially point 2.
https://docs.npmjs.com/misc/disputes#description