Emmanuel Bouton comments

Results 9 comments of


                                            Emmanuel Bouton

If ESME does not handle a PDU, a GenericNack should be returned instead of the corresponding Response

I'm not sure about that, but I think some SMSC will expected you to send GenericNack if you do not handle DataSM at all. The spec is clear with that,...

If ESME does not handle a PDU, a GenericNack should be returned instead of the corresponding Response

That would be great, because we should be able to introduce a system of windowing on ESME side. @linxGnu : I think you missed something when you merged #61 ......

If ESME does not handle a PDU, a GenericNack should be returned instead of the corresponding Response

Of course ... sorry I'm a little bit tired :joy:

If ESME does not handle a PDU, a GenericNack should be returned instead of the corresponding Response

I had a chat with our SMSC expert ... In case of ESME does not handle some kinds of PDUs, we should not respond a Generic Nack because in this...

If ESME does not handle a PDU, a GenericNack should be returned instead of the corresponding Response

Yes ... but that's a problem if we introduce a `PDUResponder` in `Settings` like @bachhh suggests.

Handling custom runes mapping

Another thing about charset tables, it would be great if we can have the possibility to set a default character in case of a mapping is not found (instead of...

Add possibility to specify address range when binding with SMSC

lgtm

Add possibility to specify address range when binding with SMSC

@laduchesneau : Even if it's technically possible to provide address_range in a transmitter bind, it is not expected according to the specification : > The address_range parameter is used in...

Context.sess should be public ?

Hi @freedom9527, I'm using this library in a fake SMPP server, so I forked and made the Context.Sess variable public. I'd prefer a better approach :)