gosmpp icon indicating copy to clipboard operation
gosmpp copied to clipboard

Add possibility to specify address range when binding with SMSC

Open Hurtsich opened this issue 1 year ago • 3 comments

We're using the lib to connect to SMSC but there was no way to setup the address range parameter within the connector. We saw that the bindRequest struct was responsible for it and we took the freedom to improve the way we instantiate the connector. With this pull request you can see that on the Receiver and Transceiver, we can now modify the connector without breaking the public interface of the lib. Which can now be used to add the addressRange option.

Hurtsich avatar Jan 11 '24 15:01 Hurtsich

lgtm

goten4 avatar Jan 11 '24 16:01 goten4

My two cents, the Functional Option should also be added to Transmitter bind, address_range (addr_ton, addr_npi) are allowed in the bind_transmitter body.

laduchesneau avatar Jan 11 '24 18:01 laduchesneau

@laduchesneau : Even if it's technically possible to provide address_range in a transmitter bind, it is not expected according to the specification :

The address_range parameter is used in the bind_receiver and bind_transceiver command to specify a set of SME addresses serviced by the ESME client.

goten4 avatar Jan 11 '24 18:01 goten4