Mo Gorhom comments

Results 133 comments of


                                            Mo Gorhom

[v4] animatedKeyboardHeightInContainer is 0 when Keyboard is open

this will be fixed with `v5`

Build 3rd party plugins that optimize Sagas usage (following this blueprint) [and another for Redux-Observable]

@ScriptedAlchemy it would be great if this library could split into two libraries as well: - Library #1: handling history/routes other common utils. - Library #2: works as an adapter...

Use contextBridge?

good suggestion, i will look into , but feel free to submit a CR and i'll look into it this weekend

@natew thanks for the suggestion, the library seemed to expose the internal contexts, but there is something wrong with passing values https://github.com/gorhom/react-native-portal/assets/4061838/0e8f371d-0476-4e33-85db-dae7a404ad14

Use contextBridge?

i think i found the issue with the memoized bridge that it returns https://github.com/pmndrs/its-fine/blob/main/src/index.tsx#L221-L233 the equality check does not run a deep equality check which causes the return memoized value...

fix: replace getRefNativeTag with findNodeHandle

tested v5 with/without new arch, it is not throwing this error

fix: replace getRefNativeTag with findNodeHandle

@AndreiCalazans sorry i have been very busy with work lately,, just to confirm is this fix backward compatible with old arch ?

fix: replace getRefNativeTag with findNodeHandle

thanks for confirming @AndreiCalazans , this fix should be out for the next releases of `v4` and `v5`

fix(BottomSheetContainer): cannot add new property 'value'

thanks for your contribution ,, i apologise for merging late

[v4] | [v2] Initial Closed State with index prop not working properly...

@pdesign why not just submitting a expo snack to help me debug it faster :(