react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

fix(BottomSheetContainer): cannot add new property 'value'

Open MoritzCooks opened this issue 1 year ago • 2 comments

Motivation

Currently the v4 faces the issue cannot add new property 'value' (have a look at https://github.com/gorhom/react-native-bottom-sheet/issues/1292 and https://github.com/gorhom/react-native-bottom-sheet/pull/1293) Those were automatically closed without fixing the issue.

To fix that issue, BottomSheetContainer.tsx has to check if containerOffset.value is available.

MoritzCooks avatar Apr 19 '24 12:04 MoritzCooks

One more try 😄 You will not get rid of me @gorhom !

MoritzCooks avatar Apr 19 '24 12:04 MoritzCooks

My two previous PRs got automatically closed:

  • https://github.com/gorhom/react-native-bottom-sheet/pull/1650
  • https://github.com/gorhom/react-native-bottom-sheet/pull/1758

Please have a look at it. It's just one line to prevent a potential undefined containerOffset which happens in some cases.

MoritzCooks avatar Apr 19 '24 12:04 MoritzCooks

thanks for your contribution ,, i apologise for merging late

gorhom avatar May 19 '24 16:05 gorhom

thanks for your contribution ,, i apologise for merging late

No worries 🙂

MoritzCooks avatar May 27 '24 16:05 MoritzCooks