Mo Gorhom comments

Results 133 comments of


                                            Mo Gorhom

[v4] Bottom sheet is not dismissed if `dismiss` is called soon after `present`

https://github.com/user-attachments/assets/88a30cef-688e-47d8-98a0-122a2454ceb5

[v4] Bottom sheet is not dismissed if `dismiss` is called soon after `present`

@celian-riboulet woah,, that is bad ,, working on a fix

[v4] Bottom sheet is not dismissed if `dismiss` is called soon after `present`

@celian-riboulet may i know why are you mounting and unmounting the bottom sheet modals? this is causing an internal issue and might take me time to fix it. You could...

fix: set containerHeight to value or initial container height

thanks @InnigerM for submitting this PR, i have pushed a new release that rewrite the entire layout logic, and i think it should address your issue. Would you mind testing...

try getScrollableNode in findNodeHandle.web.ts

@btoo @robertkossendey if you could provide me more details on the issue, maybe repo sample code then i can investigate it

Avoid deprecated AnimateProps type

i will look into it tomorrow, thanks for submitting this PR

[Bug]: Changing FlatList data causes bottomsheet to close

looking at the issue at the moment

[Bug]: Changing FlatList data causes bottomsheet to close

im not able to repo the issue,, could you someone provide a repo sample code base so i could investigate the issue ? https://github.com/user-attachments/assets/939e7db2-b7d6-4b63-84bd-f9904543386f

[Bug]: Blur effect isn't applied to the background if `handleComponent` is set to `null`

interesting bug! handle component has nothing to do with the background yet it impacts it

[Bug]: Blur effect isn't applied to the background if `handleComponent` is set to `null`

i think we need to investigate the blur view mounting mechanism, because from this library, we do render the background component regardless of the handle component. but it seems that...