gapic-generator-java

gapic-generator-java copied to clipboard

Paged Callables are not being Traced

2

From gRPC's CallableFactory: https://github.com/googleapis/sdk-platform-java/blob/ba648ceac869d4fab1a9cbeb40f2e04f69dad4e3/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallableFactory.java#L129-L139 Paged Callables do not have a TracedPagedCallable equivalent which implements tracing. It is possible that we can reused the TracedUnaryCallable, but that requires some investigation.

lqiu96

Non-primitive values should not be put into path parameters

6

Similar to #1016 _In some cases, the generated client library would put complex object to ~query~ path parameters, like [here](https://github.com/googleapis/gapic-generator-java/blob/889f316d7dfcfdaf826cb8024166cc8eabeaef0d/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/HttpJsonComplianceStub.golden#L176) , the proto definition for this method is [here](https://github.com/googleapis/gapic-generator-java/blob/889f316d7dfcfdaf826cb8024166cc8eabeaef0d/src/test/proto/compliance.proto#L64). The...

diegomarquezp

Why didn't a check detect the inconsistent protobuf version 3.23.3 when the shared dependencies BOM had 3.23.2?

1

Why didn't a check detect the inconsistent protobuf version 3.23.3 when the shared dependencies BOM had 3.23.2? Detecting the discrepancy in java-cloud-bom is late https://github.com/googleapis/java-cloud-bom/actions/runs/8476531114/job/23226189124. That discrepancy should have been...

suztomo

Thanks for stopping by to let us know something could be better! **Is your feature request related to a problem? Please describe.** Google Copyright should be written similar to `Copyright...

lqiu96

Generator incorrectly sets the composeTransport sample's region tag

3

Context: The SyncCreateSetCredentialsProvider sample already exists: https://github.com/googleapis/google-cloud-java/blob/56c9a8a29c1d04baed958cc028918eea5995aa17/java-tpu/samples/snippets/generated/com/google/cloud/tpu/v2/tpu/create/SyncCreateSetCredentialsProvider.java and it properly showcases setting the credentials. The SyncCreateSetCredentialsProvider1 sample should be named something that reflects that it is using httpjson. This generator's...

lqiu96

We should exclude fields from query params if the fields are already configured for path params or body. See [here](https://github.com/googleapis/googleapis/blob/532289228eaebe77c42438f74b8a5afa85fee1b6/google/api/http.proto#L208) for the detailed rules for mapping http annotation to body/path...

blakeli0

feat: gapic-generator-java to perform a no-op when no services are detected

10

Fixes https://github.com/googleapis/sdk-platform-java/issues/2050 Adds behavior to gracefully perform a NOOP if no services are contained in the generation request. ## Confimation in hermetic build scripts From `generate_library.sh` against `google/cloud/alloydb/connectors/v1` ``` +...

diegomarquezp

chore: gapic-generator-java noop follow up on hermetic build scripts

2

This is a follow up from https://github.com/googleapis/sdk-platform-java/pull/2460. The checks should pass once it is merged in main and this PR is rebased/updated with the new changes. Since GGJ will NOOP...

diegomarquezp

gax-java(mac): Flaky AbstractRetryingExecutorTest.testCancelOuterFutureBeforeStart

3

[Flake](https://github.com/googleapis/gapic-generator-java/actions/runs/4179720242/jobs/7239981015) in nightly build for mac Java 17 ``` Error: com.google.api.gax.retrying.ScheduledRetryingExecutorTest.testCancelOuterFutureBeforeStart[Custom retry settings: false] Time elapsed: 0.021 s at com.google.api.gax.retrying.FailingCallable.call(FailingCallable.java:85) Actually, above is the only interaction with this mock. at...

burkedavison

**Is your feature request related to a problem? Please describe.** In Storage SDK (java-storage); we are looking at introducing a new zero copy response marshaler for ReadObject request. It currently...

frankyn