gapic-generator-java

gapic-generator-java copied to clipboard

Handle `google.rpc.ErrorInfo` in HttpJson*Stub class

6

Followup on #2229. The generated HttpJsonEchoStub can't handle message type: `google.rpc.ErrorInfo` introduced by `echo.proto` (version `0.29.0`). A easy integration test: ``` @Test public void testEchoErrorDetails() { EchoErrorDetailsResponse response = httpjsonClient.echoErrorDetails(...

JoeWang1127

Introduce [Awaitility](https://github.com/awaitility/awaitility) or another tool that can be used to test async operations. Ideally the code would be written something like `await().atMost(5, SECONDS).until(doSomething())` There are a probably a few spots...

lqiu96

There are several manually written `hashcode()` methods in the generator: 1) TypeNode: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/TypeNode.java#L256 2) Field: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Field.java#L109 3) ScopeNode: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/ScopeNode.java#L67 4) VaporReference: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/VaporReference.java#L125 5) ResourceName: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/ResourceName.java#L147 6) MethodArgument: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/MethodArgument.java#L63 7) https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/ResourceReference.java#L44...

alicejli

Add toString for InstantiatingGrpcChannelProvider

1

**Is your feature request related to a problem? Please describe.** When debugging customer issues it is very useful to get a copy of the settings that they are using. Unfortunately...

igorbernstein2

feat: extend Callables class to let client pass in a custom retry algorithm

2

Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://github.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md) Before submitting your PR, there are a few things you can do to make...

mutianf

Implement downstream javadoc generation test on sdk-platform-java

3

To help catch javadoc errors upstream, implement a downstream check on the generator similar to this one: https://github.com/googleapis/java-shared-config/pull/662/ that checks javadoc generation on a couple of libraries to ensure javadoc...

alicejli

BlockingProcessStreamReader stalls when a subprocess is waiting on user input

1

After analysing https://github.com/googleapis/java-datastore/issues/302 , we have a scenario where in some cases user can run commands which requires user input (manual intervention) and in those cases BlockingProcessStreamReader blocks on the...

jainsahab

feat: Mark `getDefaultEndpoint()` with @ObsoleteApi

1

The endpoint is not longer set with the default endpoint. The EndpointContext will be able resolve the client's endpoint

lqiu96

Changes: - The `getDefaultEndpoint()` will be marked with `@ObsoleteApi` annotation with the intention of removing it in a future major version bump. - The generated ServiceStubSetting classes will no longer...

lqiu96

chore: auto-generate Spanner RPC Options

2

**DO NOT MERGE, PROTOTYPE/EXPERIMENT ONLY** Writing a new composer to auto-generate a Spanner hand-written Java class. Refer class `AutoGeneratedOptions` in https://github.com/googleapis/java-spanner/pull/2716/

arpan14