Non-primitive values should not be put into path parameters

[diegomarquezp]

Similar to #1016 In some cases, the generated client library would put complex object to ~query~ path parameters, like here , the proto definition for this method is here. The generated client library will error out during runtime if non-primitive values are put into query parameters.

[suztomo]

Is this causing a problem somebody suffers from?

[blakeli0]

This is hypothesis scenario, we don't have a service proto that is configured this way. But if they do, the generated code would error out during runtime.

[suztomo]

My impression is that if such proto file is introduced it breaks most of the languages. Or is there a specification that GAPIC generator Java hasn't implemented yet?

[blakeli0]

I don't think we have an AIP or similar specification that forbid this scenario, the comment in the proto is the closest thing. Yes you are probably right that it would most likely break other languages as well. Ideally this should be validated in a language neutral tool like APILinter as well.

[suztomo]

So the proper solution seems not to make the Java generator to work with such proto files (somehow), but to prevent such proto files.

[blakeli0]

So the proper solution seems not to make the Java generator to work with such proto files (somehow), but to prevent such proto files.

Agreed. Maybe it was not clear, what proposed in this issue is to add validation in the Java generator so that the generator would error out instead of erroring out during runtime, if we are not going to do it in a platform level tools.