goodboy

Results 746 comments of goodboy

>as such, as soon as trees of conftests that use pytest_plugins, we get a inconsistent dependency state of plugins @RonnyPfannschmidt do we have an example of this being a problem?...

@RonnyPfannschmidt If you can give me an example of this problem it'd be super helpul ;) >we get a inconsistent dependency state of plugins Mostly I just need to have...

@pombredanne sounds good. I'm sure it will at the least provide ideas for what @RonnyPfannschmidt desires here.

Just wanted to link to pytest-dev/pytest#3084 as a related deprecation due to this limitation.

@fschulze why can't you add the new argument to the `hookspec` and then then call the hook using both the new and old argument (`hookimpl`s don't have to declare all...

Shoot just realized #138 is only for [deprecating full hooks](https://pluggy.readthedocs.io/en/latest/#warnings-on-hook-implementation) and **not** specific args. @RonnyPfannschmidt what do you think about something similar like: ```python @hookspec( warn_on_args={'arg1': DeprecationWarning("arg1 is deprecated and...

>doesn't work even remotely since it ignores stuff like caller handling @RonnyPfannschmidt explain? Also what are you referring to with this comment? >that still wouldn't solve the issue, that the...

>hook calls are in plugins, now plugins are broken in fun ways as all of them would have a breaking change I'm not following - where's the breakage? This new...

@RonnyPfannschmidt right which is why you first deprecate and **then later remove** - just like any API progression? If you're going to deprecate and change an API at some point...