goodboy

Results 746 comments of goodboy

>all callers must include all arguments - so i have no idea what you are talking about Yes - no confusion there. So you change the spec to include `warn_on_args`...

Why? A call [can not declare all args that are in the spec](https://github.com/pytest-dev/pluggy/blob/master/pluggy/hooks.py#L278) (you'll get a warning) as well as adding a new arg to both the call and spec...

>for example if pytest_deselected(items) changed to pytest_deselected(items, reason) The question is *where* is this *changed*. If it's in the *spec* then everything will work since `warn_on_args` is also *on the...

> im out of this :disappointed: >Does it work already, or does pluggy need to add some introspection facilities? @fschulze not yet but like I said #57 would bring it....

Just copying a comment from @fschulze from the #57 PR. >edit: sorry to have added this comment on this not entirely related PR, I thought I was replying on #170....

@fschulze if I understand this correctly you're looking for something like: ```python for result in pm.hook.myproject_get_password(arg1=1, arg2=2): if not result: # skip to the next hookimpl continue else: success =...

@fschulze I looked into this briefly and it seems to me in order to avoid transforming `pluggy.callers._multicall()` into a generator function (which has a ~4x slowdown per call if use...

@RonnyPfannschmidt it's basically just rewriting that function to `yield` values in stead of appending them the list. The only real challenge is how to expose it. I can draft up...

>After all even if the hook caller decides to stop the iteration, the "after" hooks can still be called I believe. Yep, totally agree it's straightforward. ~with the only caveat...

@RonnyPfannschmidt I could see that yeah. I like context managers 👍 - explicit is always better.