goodboy

Results 747 comments of goodboy

Ahh yeah so there's an import cycle in this.. I need to break out the `_Result` into it's own module, any preferences on a name? I was thinking `_result.py` ?...

One other idea: given the `.pyx` code isn't yet truly written as native `cython` code we could just breakout `_multicall()` to a new module and then copy and cythonize it...

>I proposed this before in #227 so +1 from me @bluetech I might add it in in a new PR just so that it can come in before this one...

Got the benchmarks running with both. See the results from my terminal: ![screenshot-2020-06-04_14-58-44](https://user-images.githubusercontent.com/291685/83800005-b4535a00-a674-11ea-8727-592e12d7baa9.png)

@bluetech sounds good! I'm just gonna put up a PR to split out the `_Result` and friends and then this will basically be ready once I rebase on that.

I rebased this onto #268 so once that's merged I'll rebase onto `master` again to factor out those commits.

>So it's a 5% improvement. Yeah nothing to write home about. >IMO, 5% is probably not enough to be worth it, given that Cython, C extensions, wheels etc. are a...

Check this out. @oremanj just pointed to [mypyc](https://github.com/python/mypy/tree/master/mypyc) in the `trio` gitter which might be worth investigating as well for other modules in `pytest` and `pluggy`. I know @bluetech is...

@RonnyPfannschmidt agreed just thought I'd log it for future reference/discussion.

@RonnyPfannschmidt wait doesn't #52 provide a way to address this? We can temporarily register `contest.py` plugins for each path - de-registering as each new path is used?