Michael Goderbauer

Looks like the checks are unhappy, though.

@piedcipher Do you still have plans to get back to this PR and resolve the feedback given above?

Now you just have to revert **all the changes** to the following files: * `packages/flutter/lib/src/material/input_chip.dart` * `packages/flutter/lib/src/material/app_bar.dart`

Looks like this is failing our checks. Can you please take another look at those? Thanks!

If you click through the checks, you will see that one test is failing: ``` 02:18 +2024 ~2: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/tooltip_test.dart: Tooltip should not ignore users tap on richMessage ══╡ EXCEPTION CAUGHT...

I did some digging and wasn't able to find a reason why we wrapped the Tooltip with an IgnorePointer in the first place. Also looks like all tests are still...

cc @dnfield @polina-c

Figured out that the leaks are orginiating from here: https://github.com/flutter/flutter/blob/5120a0df6291bc56437ad434582ea2472f9ac66c/packages/flutter_test/lib/src/_goldens_io.dart#L192 https://github.com/flutter/flutter/blob/5120a0df6291bc56437ad434582ea2472f9ac66c/packages/flutter_test/lib/src/_goldens_io.dart#L197 Fix is straight forward. I wonder, why these lines are not appearing in the stack trace?

Stack traces of remaining leaks: ``` notDisposed: total: 2 objects: ValueNotifier: identityHashCode: 351055822 context: start: > #0______ObjectTracker.startTracking_(package:leak_tracker/src/_object_tracker.dart:64:64) #1______dispatchObjectEvent_(package:leak_tracker/src/_dispatcher.dart:40:19) #2______dispatchObjectEvent._(package:leak_tracker/src/leak_tracker.dart:91:16) #3______dispatchObjectEvent_(package:leak_tracker/src/leak_tracker.dart:94:4) #4_______withFlutterLeakTracking.flutterEventToLeakTracker_(file:///Users/goderbauer/dev/flutter/packages/flutter/test/foundation/leak_tracking.dart:109:12) #5______MemoryAllocations.dispatchObjectEvent_(package:flutter/src/foundation/memory_allocations.dart:238:23) #6______MemoryAllocations.dispatchObjectCreated_(package:flutter/src/foundation/memory_allocations.dart:272:5) #7______new_ValueNotifier_(package:flutter/src/foundation/change_notifier.dart:508:34) #8______new_OverlayEntry_(package:flutter/src/widgets/overlay.dart:141:79) #9______ModalRoute.createOverlayEntries_(package:flutter/src/widgets/routes.dart:1757:21) #10_____OverlayRoute.install_(package:flutter/src/widgets/routes.dart:59:28) #11_____TransitionRoute.install_(package:flutter/src/widgets/routes.dart:265:11) #12_____ModalRoute.install_(package:flutter/src/widgets/routes.dart:1235:11) #13______RouteEntry.handleAdd_(package:flutter/src/widgets/navigator.dart:2903:11)...

From what I can tell, the leaking ValueNotifier is this one here: https://github.com/flutter/flutter/blob/5120a0df6291bc56437ad434582ea2472f9ac66c/packages/flutter/lib/src/widgets/overlay.dart#L141 Here are some pointers that could be the source of the leak: That ValueNotifier is only conditionally...