Gnought

Removed obsolete tests

5

Those tests have been moved into aedes-protocol-decoder repo

Make tests that after connected/clientReady event.

26

We assumed that client connection is ready when writing mqtt packets, we strengthen tests not to have race conditions.

Custom Error class and use enum to replace error message

6

Any errors raised now are using `Error(message)`, should we have a custom error class and replace message as a enum for better handling?

[feat] Validate ClientId

3

Based on the MQTT 3.1.1 spec: > The ClientId MUST be a UTF-8 encoded string as defined in Section 1.5.3 [MQTT-3.1.3-4]. > > The Server MUST allow ClientIds which are...

Is `AedesClient` better to state that it is in aedes scope? https://github.com/moscajs/aedes/blob/d64faebbd133d167b2c066b2a0fc264624e4a5a4/aedes.d.ts#L74

[feat] Check the returned subscription in authorizeSubscribe

1

the returned subscription currently is checked, `!sub || typeof sub !== 'object'`, it is better to validate also if it matches `{ topic: 'xxx', qos; [0|1|2|128] }`

Ways to promisify aedes-codebase friendly.

7

Please suggest preferable ways to make aedes-codebase be promise friendly?

Function vs Class

1

Could we use `class` to replace `function ` for initiating object like `PubRel` ?

Compile error for 4.14 (on MIPS)

6

It compiles fine in master branch at 5f188b7b4b0dfc9b9b4445700ad02d0078198bb7 but we get a compile error using master branch as 6a55739a9bf9fb890dbd1aa338057f394b766ab8 ``` bash # ./configure --kdir=/tmp/kernel --ipt-bin=/tmp/vroot/sbin/iptables --ipt-lib=/tmp/vroot/lib/xtables --ipt-inc=/tmp/vroot/include --enable-natevents --enable-snmp-rules --enable-macaddress...

Missing postNAT fields in netflow v9 flow records

1

Adding netflow capture on PREROUTING and POSTROUTING chains, I found that the netflow v9 flow record does not contain `postNAT` fields. They are only in NAT events. Is it by...