aedes icon indicating copy to clipboard operation
aedes copied to clipboard

Removed obsolete tests

Open gnought opened this issue 5 years ago • 5 comments

Those tests have been moved into aedes-protocol-decoder repo

gnought avatar Feb 07 '20 17:02 gnought

In case of' websocket-stream updated to ws' those were useful to check there was breaking changes on protocol-decoder. Like the _socket property that wasn't present

robertsLando avatar Feb 07 '20 17:02 robertsLando

Please test it in aedes-protocol-decoder.

gnought avatar Feb 07 '20 17:02 gnought

Would also decrease coverage, i think we need at least one test that uses decode protocol

Daniel

On 7 Feb 2020, at 18:05, Gnought [email protected] wrote:

 Please test it in aedes-protocol-decoder.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando avatar Feb 07 '20 17:02 robertsLando

@gnought I suggest to create a dummy protocol decoder test that simply parse data

https://github.com/moscajs/aedes/blob/master/lib/client.js#L80

robertsLando avatar Feb 08 '20 12:02 robertsLando