Mponos George

Results 36 comments of Mponos George

IMHO you should use both codesniffer and PHP-CS-Fixer for different reasons. **Codesniffer** - configurable through XML and has many config options - It's not only about "style" but more into...

Well.. in a way I agree with @Taluu .. many things will be covered by codesniffer if you install slevomat

> What are the benefits of using Slevomat's rule instead of PHPCS'? 1. phpcs is a warning. Can be easily converted to error.. no problem here. 2. there is no...

If you want my opinion I would prefer using the phpcs one instead of slevomat even without the autofix.

No no... I think the intent of `Squiz.PHP.NonExecutableCode` is what it is.. Not sure if doctrine org intentions was to have it as a warning or if you just missed...

Hello, I haven't seen any related package being created since the report of these issue (although it's not so old issue). But because there was a need in my projects...

I tried to see if there was any related comment but I could not find anything. Forgive me if I am mentioning something that it is already said. I copy...

Hello @mathroc , unfortunately it does not work good with doctrine. ``` use Doctrine\ORM\Mapping\UniqueConstraint; /** * @ORM\Entity(repositoryClass="\MyEntityFQN") * @ORM\Table(name="mytable", uniqueConstraints={@UniqueConstraint(...), @UniqueConstraint(...)})) */ ``` It finds the UniqueConstraint as unused :(

I don't think this is the issue. https://regex101.com/r/2IRwNW/1 Anyway. I would not suggest doing this back and forth test thing. (giving me changes to test). It's not very efficient. 😄

The work around that I found was this: ``` public function setUp() { parent::setUp(); $this->client = static::createClient(); $this->containers['|test'] = $this->client->getContainer(); $this->loadFixtures($this->getFixtureData()); } public function tearDown() { unset($this->containers); unset($this->client); parent::tearDown(); }...