coding-standard icon indicating copy to clipboard operation
coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon doctrine

Remove PSR12.Properties.ConstantVisibility in favor of slevomat

Open gmponos opened this issue 4 years ago • 2 comments

Isn't this already checked by slevomat?

Does the one cover cases that the other does not? Then if yes.. shouldn't the PSR12.Properties.ConstantVisibility be turned to an error.. because currently it is a warning

gmponos avatar Jun 19 '20 09:06 gmponos

What are the benefits of using Slevomat's rule instead of PHPCS'?

  1. phpcs is a warning. Can be easily converted to error.. no problem here.
  2. there is no autofix.. The policy of phpcs maintainer -which I agree with- is a little bit defensive against these kind of autofix

gmponos avatar Jun 23 '20 08:06 gmponos

If you want my opinion I would prefer using the phpcs one instead of slevomat even without the autofix.

gmponos avatar Jun 23 '20 08:06 gmponos