Glenn Lewis

Results 435 comments of Glenn Lewis

> @gmlewis pardon me if this comes off as hasty, I just kind of want to switch my go.mods off of my fork, and open up this PR to see...

Thank you, @raynigon ! Merging.

@amitsaha - it looks like one of the examples needs to be updated. Please run `go test ./...` from the base directory of the repo to make sure all tests...

> @gmlewis Thanks! I know we had a new release just days back, is there any chance I can request you for a new release with this change? Yes, I...

https://github.com/google/go-github/releases/tag/v47.0.0 now contains this change.

Hmmm... that does indeed look unusual. In the corresponding unit test, it shows `TextMatch` being used with `client.Search.Code`: https://github.com/google/go-github/blob/master/github/search_test.go#L408-L413 Although the official documentation shows an example using the `issues` endpoint:...

Ah, yes, thank you, @emilva ! Would you like to submit a PR to rectify this, or shall I open it up to the rest of the contributors to this...

> Yes, I will try to open PR shortly! Thank you, @emilva ! It's yours. :smile: