Add ListOptions for listing user migrations
Fix for https://github.com/google/go-github/issues/2416
Codecov Report
Merging #2417 (a518e88) into master (01c8feb) will decrease coverage by
0.02%. The diff coverage is40.00%.
@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
- Coverage 98.06% 98.03% -0.03%
==========================================
Files 122 122
Lines 10687 10690 +3
==========================================
Hits 10480 10480
- Misses 142 144 +2
- Partials 65 66 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| github/migrations_user.go | 91.08% <40.00%> (-2.79%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@amitsaha - it looks like one of the examples needs to be updated. Please run go test ./... from the base directory of the repo to make sure all tests pass. Please see CONTRIBUTING.md for more details. Thanks.
@amitsaha - it looks like one of the examples needs to be updated. Please run
go test ./...from the base directory of the repo to make sure all tests pass. Please see CONTRIBUTING.md for more details. Thanks.
Thanks. I did that before I pushed my branch:
$ go test ./...
go: downloading golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be
go: downloading golang.org/x/net v0.0.0-20210226172049-e18ecbb05110
ok github.com/google/go-github/v45/github 0.840s
? github.com/google/go-github/v45/test/fields [no test files]
? github.com/google/go-github/v45/test/integration [no test files]
From the linting failures above I can see that there is an example needed to be updated, so I can see the failure when I run go test from within the example directory.
Not sure if I am doing something wrong?
Updating with the fix.
Thanks @gmlewis !
@gmlewis Thanks! I know we had a new release just days back, is there any chance I can request you for a new release with this change?
@gmlewis Thanks! I know we had a new release just days back, is there any chance I can request you for a new release with this change?
Yes, I think the worst thing that would happen is I might annoy some people, but that's OK. I've done it before and survived. :joy:
@gmlewis Thanks! I know we had a new release just days back, is there any chance I can request you for a new release with this change?
Yes, I think the worst thing that would happen is I might annoy some people, but that's OK. I've done it before and survived. joy
Thanks a lot!
https://github.com/google/go-github/releases/tag/v47.0.0 now contains this change.