Glenn Lewis comments

Results 435 comments of


                                            Glenn Lewis

[v1.23] Testing the new `iter` package with `gh-iter`

This also relates to: * #2618 * #3504

CustomProperty and DefaultValue of null value is allowed by the API but not the SDK (?)

I believe this is a duplicate of #3692.

Inconsistency between events API and webhook payload

My understanding is that you wish to split `WebHookPayload` and `PushEvent` into two separate structs so that fields that are no longer populated will no longer exist in the struct,...

Inconsistency between events API and webhook payload

> Then maybe it would be enough to update the comment in the code that the deprecation is (currently) relevant just for events API. That sounds like an excellent idea....

refactor!: Refactor GistsService to use value parameters

@stevehipwell and/or @alexandear - do you approve this PR now?

Refactor codebase to use value parameters instead of pointers where appropriate

> Does the issue need to be assigned or can I push a PR for this? I was wondering how i would be separating the PRs because changes would be...

Refactor codebase to use value parameters instead of pointers where appropriate

> Hi, due to work constraints, I am not too sure if I can finish this issue by myself, or at least anytime soon so if anyone wants to continue...

Refactor codebase to use value parameters instead of pointers where appropriate

> Hi, I’d like to work on this issue. Could you please assign it to me? Thank you, @sarthakw7! It is yours.

Refactor codebase to use value parameters instead of pointers where appropriate

> I want to help with this issue [@gmlewis](https://github.com/gmlewis) Thank you for your interest, @alkak95! @sarthakw7 - are you OK if I switch ownership of this issue to @alkak95?

Refactor codebase to use value parameters instead of pointers where appropriate

I apologize that this wasn't clear before, but in this issue we are only talking about parameters of _exported_ methods, not internal methods. There is nothing inherently wrong or bad...