Georg Mischler

Results 71 comments of Georg Mischler

> I am fairly sure we would `image` to always respect the bottom margin, despite passing a custom `y`, so that should probably be fixed. I don't think this is...

It looks like your text contains some unusual non-printing characters. Being unusual results in them not being present in some popular fonts. Being non-printing results in them not showing up...

If a character actually has a visible glyph, then the warning message you received would show that. But it obviously doesn't in your case. There are many unicode characters that...

Please check the pylint output and fix any issues it brings up. You'll also need to rebase your branch, and resolve any conflicts that brings up. And then I have...

> I get a curve with a fill and stroke, one with just a fill, and one with just the stroke. Looks great! This appears to be pretty much complete...

Two last little nitpicks: you need to run black on your code, it blocks the testing pipeline. And I just noticed that you still have a `debug_stream=None` parameter in the...

> Should I be getting a debug_stream from somewhere else? Or just remove it? (Removed for now.) Removing it is fine, as long as you do it in the docstring...

There's still an unresolved conflict in CHANGELOG.md (even if github doesn't seem to detect it).

Thanks for this helpful feature addition, @awmc000 ! merging now.

Welcome to fpdf2, @carlhiggs ! Yes, this is one of the many limitations that currently plague our template system (as evicenced eg. by #1119). One of the reasons for that...