Georg Mischler

Results 71 comments of Georg Mischler

> @gmischler: this seems related to the text regions / paragraph rendering logic: would you like to have a look at this? 🙂 I think it has always behaved like...

> `, and ` all create paragraphs and pdf has an l_margin. Why not keep a stack of l_margins and push onto it each time you see one of these...

I think supporting different "indentation elements" within a single paragraph makes things unnecessarily complicated. You probably chose to do it this way because the html module currently creates a paragraph...

> An 'indentation element' in this context would be something like this string `f"{indent_string}{bullet} "` This is exactly what we want to get rid of here. The paragraph should only...

>1. The way I implemented it, the indentation of ``elements is now done using the same units that are used for `Fragment.get_width()`, instead of concatenating whitespace characters together. It took...

> > Although I'm not sure if 7.831666666666665 is really a good default value. How did you arrive at that? > > I got that from `Fragment.get_width()` of default indentation...

@allcontributors please add @carlhiggs for code

Thanks for the contribution, @carlhiggs ! Merging now.

>I think drawing.py has some functions inside it, right? As mentioned in the issue description, the drawing.py module has several classes that implement the geometric calculations: * [BezierCurve()](https://github.com/PyFPDF/fpdf2/blob/4bcd4559ac9dea1f1e2d12a96f934fa5643983ee/fpdf/drawing.py#L2015) * [RelativeBezierCurve()](https://github.com/PyFPDF/fpdf2/blob/4bcd4559ac9dea1f1e2d12a96f934fa5643983ee/fpdf/drawing.py#L2087)...

@jeettrivedi, you might want to check out the svg.py module and compare how it uses the bezier methods in drawing.py. You can probably keep it simpler than that because you...