Giuseppe comments

Results 90 comments of


                                            Giuseppe

ghprb not automatically setting webhooks with correct `events`

Just wanted to add, that if there is **both** a ghprbhook and an SCM on-push enabled (Github plugin), then the github plugin will work. If there is only SCM on-push...

Go binding: add StopNetwork()

Cc @vishesh @ajbeamon, as I saw you were involved in discussing #3015

Not all binding implementations follow the requirements of fdb_stop_network

> In Go land, it seems a bit harder to do. Indeed it is. This is the best I could come up with: ```go //go:linkname runtime_addExitHook runtime.addExitHook func runtime_addExitHook(f func(),...

Go binding: do not automatically close database objects

Cc @johscheuer Alternative approach would be: to use an `atomic.Value` or a mutex to make sure that calling `destroy()` multiple times is safe. I can change the PR for that...

Go binding: do not automatically close database objects

> I have to take some time to go over the changes. Understood, thanks for the info; I would prefer as well that you take all the time needed as...

Go binding: do not automatically close database objects

Thanks!

Using a restart_delay override creates a cluster with a persistent IncorrectProcess reconciliation problem

Forgot to mention: I haven't yet looked into code for a possible bugfix, but if I find the cause I'll submit a PR.

Using a restart_delay override creates a cluster with a persistent IncorrectProcess reconciliation problem

It is probably as you write; I made this PR for an unrelated trivial improvement: https://github.com/FoundationDB/fdb-kubernetes-operator/pull/1977 But could not find anything obviously wrong in `GetMonitorProcessConfiguration()` and its usage.