Giuseppe

Results 31 comments of Giuseppe

It's happening because `command` should be a string, not an array.

This is my (dirty) fix: ```diff diff --git a/channel.go b/channel.go index dd2552c..f90d823 100644 --- a/channel.go +++ b/channel.go @@ -297,7 +297,12 @@ func (ch *Channel) dispatch(msg message) { } ch.notifyM.RUnlock() ch.consumers.cancel(m.ConsumerTag)...

> I don't like how returns and acks are intertwined in your example Me neither! I was hoping that by showing where the pain is, you could come up with...

I would be interested in an example for graceful termination e.g. upon SIGTERM or SIGINT, expect the robot to terminate gracefully and exit. I could not find an (exposed) channel...

#528 has been closed. If moving to logrus is a too big task, can we consider allowing injection of a logger through an interface instead?

Most other libraries/frameworks allow to override the default logging mechanism with a call like `SetLogger(...)`; so for gobot it could be either that or an option specified with a `.WithOption(...)`...

It would be nice if the control flow was manageable or at least inspectable externally, this would allow to coordinate with other channels/contexts.

@alecgrieser or @johscheuer, maybe you know the answer to this question? :thinking:

> The client basically validated that the transaction is read only, and if so, it doesn't make a request to the server to commit it. If no locks are involved...

> I think this is a good feature, but unless we de-dupe them it's a breaking change. @brownleej duplicates are currently going to trigger an error, I just created [this...