foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Go binding: add StopNetwork()

Open gm42 opened this issue 1 year ago • 5 comments

This PR contains the following notable changes:

  1. make sure that database creation is happening only while network thread is running
  2. panic if the call to fdb_run_network() fails, instead of logging an error only
  3. StartNetwork(), already deprecated, effectively becomes a no-op
  4. expose a new StopNetwork() method which allows to follow spec for issues like https://github.com/apple/foundationdb/issues/2978 and https://github.com/apple/foundationdb/issues/3015

Any advice for test coverage?

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [x] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [x] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

gm42 avatar May 14 '24 12:05 gm42

Cc @vishesh @ajbeamon, as I saw you were involved in discussing #3015

gm42 avatar May 14 '24 13:05 gm42

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 0f04b8d5d476d17047e448c2ad253eb5288cf08a
  • Duration 0:48:54
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 14 '24 17:05 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 0f04b8d5d476d17047e448c2ad253eb5288cf08a
  • Duration 1:04:48
  • Result: :x: FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/ycsb:${FDB_VERSION}-${COMMIT_SHA}-debug --file Dockerfile.eks --target ycsb .. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar May 14 '24 17:05 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 0f04b8d5d476d17047e448c2ad253eb5288cf08a
  • Duration 1:21:06
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 14 '24 17:05 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 0f04b8d5d476d17047e448c2ad253eb5288cf08a
  • Duration 1:24:27
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 14 '24 18:05 foundationdb-ci

@jzhou77 shall I rebase it?

gm42 avatar Jul 08 '24 14:07 gm42

@johscheuer rebased it

gm42 avatar Jul 19 '24 06:07 gm42

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 0:21:54
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 21:08 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 0:39:13
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 21:08 foundationdb-ci

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 0:46:28
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 22:08 foundationdb-ci

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 0:52:16
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 22:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 0:56:05
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Aug 02 '24 22:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 1:09:29
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 22:08 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 1:12:10
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 02 '24 22:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 872c300a5c4fd32681be606d2082d384f6277517
  • Duration 1:02:51
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Aug 03 '24 03:08 foundationdb-ci