Gloria Zhao
Gloria Zhao
> Why are we not making things more robust in or before this PR? Why have we been okay with handling any transactions with missing parents despite all of these...
I've updated the PR description to be more descriptive about what this PR does and doesn't do. The 1p1c "package relay" thing wasn't meant as false advertising; I added it...
Thanks for the review, addressed comments and - fixed a bug in `GetChildren` - expanded + added more docs to the individual logic tests - got rid of the `assert_debug_log`...
Rebased for #29735 and fixed failure.
Update since my last comment https://github.com/bitcoin/bitcoin/pull/28970#issuecomment-2025812846 Running for 20 days: - My node made 5218 package evaluation attempts (x2 = 10,436 transactions). That's ~260 attempts per day. - Of those...
debugging the p2p_opportunistic_1p1c.py failure. I think the wallet one is unrelated.
Ok ready for review again.
Addressed @theStack and @sr-gi comments. Thanks!
Since there are a few ACKs now, listing followups. I plan to open a PR for the first two immediately: - redundant comment + pass `PackageToValidate` directly https://github.com/bitcoin/bitcoin/pull/28970#pullrequestreview-2025023787 - make...
> Prints to stdout a concatenation of full help text as if you had run bitcoin-cli help on every RPC. Approach NACK to adding a bunch of code to Bitcoin...