Gunnar Liljas

Results 84 comments of Gunnar Liljas

A agree with this effort, but I believe it should go beyond just Int32Type. Every primitive type suffers from this to some extent. However, the only thing that significantly improves...

The PR is about having nullable properties on attributes, i.e MaxMessageBytes, BatchSize, EnableIdempotence, MessageTimeoutMs, RequestTimeoutMs or MaxRetries. It's not allowed. Your code will not compile if you use any of...

Well, basically you could just try to use any of the mentioned properties yourself, and you'll see that it doesn't work. Attribute property values must be compilable to constants. Nullables...

> I doubt assigning the default values only will work. That is not what the code does. The property types have changed. The end result is that the Confluent library...

Sure thing, but any suggestion what such a test would do and assert? :)

Just making sure it was noted that an e2e test was added. Testing idempotency is a bit too hidden in Kafka to be triggered from the outside, so I chose...

How are the classes mapped? Which key generator?