azure-functions-kafka-extension icon indicating copy to clipboard operation
azure-functions-kafka-extension copied to clipboard

Add EnableDeliveryReports to KafkaAttribute

Open gliljas opened this issue 5 years ago • 5 comments

Being able to set EnableDeliveryReports is quite valuable, since the collector uses ProduceAsync behind the scenes. In high volume scenarios, the difference is huge (and the delivery reports are never exposed anyway).

Also, the MaxMessageBytes value was never properly copied.

gliljas avatar Sep 30 '20 12:09 gliljas

Hi @gliljas It looks awesome. Thank you for your contributions! One last request is, could you update the documentation? I mean Readme.md of this repo.

TsuyoshiUshio avatar Oct 06 '20 01:10 TsuyoshiUshio

"Documentation" added

gliljas avatar Oct 31 '20 22:10 gliljas

Rebased

gliljas avatar Jul 08 '22 16:07 gliljas

@shrohilla

gliljas avatar Nov 06 '22 19:11 gliljas

@gliljas I would recommend to wait for PR. Post that we will look into this. 1 quick question, do you have any metric how this change will impact in huge volume scenario ??

shrohilla avatar Nov 12 '22 12:11 shrohilla