Leonid Genkin
Leonid Genkin
@yosefe @brminich WDYT? - See PR description. It looks far from perfect, but as C doesn’t really have strong enum types, I think that’s the best we can do, and...
@Artemy-Mellanox please add PR description
Please fix PR title (according to our conventions).
@ofirfarjun7 need to merge from master (as API PR was merged).
Hey, I'm getting exactly the same error as well. Does this one get any attention?
@shasson5 pipeline failure seems relevant. https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-4b2350e02c88/_apis/build/builds/52919/logs/476
@roiedanino maybe add some tests?
@shasson5 In PR description: 1. As it is not trivial, please add the "How" section. 2. Motivation ("why") - also for RC/DC support preparation. 3. Start sentences with capital letters.
Please review pipeline failures, they are relevant.
Looks mostly ok. @yosefe ?