ucx icon indicating copy to clipboard operation
ucx copied to clipboard

UCP/CORE: User memh proto v2

Open shasson5 opened this issue 3 years ago • 2 comments

What

User memh proto v2 support.

Why ?

Allow memory handle to be supplied from user in order to prevent multiple registration and improve performance.

shasson5 avatar Sep 08 '22 12:09 shasson5

When trying to remove explicit casting from uint8_t to ucs_memory_type_t the following error appears:

In file included from ucp/test_ucp_stream.cc:16:0:
/.autodirect/mtrswgwork/shasson/ucx/src/ucp/core/ucp_request.inl: In function ‘ucs_status_t ucp_request_send_buffer_reg(ucp_request_t*, ucp_md_map_t, unsigned int)’:
/.autodirect/mtrswgwork/shasson/ucx/src/ucp/core/ucp_request.inl:522:44: error: invalid conversion from ‘uint8_t {aka unsigned char}’ to ‘ucs_memory_type_t {aka ucs_memory_type}’ [-fpermissive]
                                   uct_flags);

shasson5 avatar Sep 08 '22 12:09 shasson5

@Artemy-Mellanox can you pls review?

yosefe avatar Sep 19 '22 08:09 yosefe

/azp run

yosefe avatar Sep 25 '22 17:09 yosefe

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 25 '22 17:09 azure-pipelines[bot]

@shasson5 pipeline failure seems relevant. https://dev.azure.com/ucfconsort/0b36e3f0-8ab9-4a48-b68b-4b2350e02c88/_apis/build/builds/52919/logs/476

gleon99 avatar Oct 24 '22 11:10 gleon99

@shasson5 can u pls check the failures on "roce_proto_enable" machines? it seems relevant

yosefe avatar Nov 08 '22 12:11 yosefe

/azp run

shasson5 avatar Nov 15 '22 10:11 shasson5

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 15 '22 10:11 azure-pipelines[bot]

@shasson5 pls squash

yosefe avatar Jan 04 '23 14:01 yosefe