Garrett Johnson

Amazing! Very nice work. Once it's cleaned up and ready for review I can take a look and give more detailed feedback. > ExtendedTriangle is constructing bounding sphere in .update()...

Hi @TheBlek I saw you added some new commits - is there anything you'd like me to take a look at?

> their relative performance also swaps. Maybe that's down to the machine configuration now, I don't know. Maybe your results will differ? Yeah JS benchmarks seem to be tricky. May...

Thanks for the change! Realistically I think the details of this implementation are going to be too much for me to internalize but this is clearly a big improvement in...

> To be frank, I did just port a reference C implementation of the paper :) Oh, great! I see now that you've included a reference to the c file...

Yeah this is a tricky one 🤔 Unfortunately we get no events through three.js when materials change or anything so we can't listen in that respect. I suppose the most...

Feel free to make a PR and we can get a fix in. Just checking if params exists before using it in `FadeMaterialManager` should work just fine, as well.

I see what the complexity is with providing a raw buffer to the read pixels function. I'm wondering if it makes sense to have a three.js class that wraps the...

Thanks for checking! > and this is with edited 'shapecast' (removing arrayToBox) > ... > Could we make an alternative method for internal use, which instead of passing the box3,...

Thanks for the summary! Generally this seems like a good improvement. Have you tried "solution 3", as well? Was Solution 2 still best? 3 sounds closest to what the `PQP_Distance`...