eslint-plugin-github

eslint-plugin-github copied to clipboard

Querying should be wrapped in event listeners such as `document.addEventListener('DOMContentLoaded', ...)` or a Web Component. ## 👎🏻 Examples of bad code. ```js const el = document.querySelector('.my-element') ``` ## 👍🏻 Example...

koddsson

chore: use npm link for Windows compat

1

nschonni

EX: Markdownlint lint identifies a few large sample repos to do some integration testing so changes can get a little smoke testing https://github.com/DavidAnson/markdownlint/blob/main/.github/workflows/test-repos.yml https://github.com/DavidAnson/markdownlint/blob/b8e8609f5fc12abdb7ae6fa6ee1012ce20d3d9dd/package.json#L23-L32 Not sure which ones would be...

nschonni

Usage of `title` via prop drilling not detected

15

Recently found a couple of cases of `title` attribute usage (soon to be addressed in https://github.com/github/issues/issues/7066 🙏) that are not detected by the rule. This seems to be the case...

andrefcdias

Bumps the all-dependencies group with 4 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser), [eslint-doc-generator](https://github.com/bmish/eslint-doc-generator) and [eslint-plugin-eslint-plugin](https://github.com/eslint-community/eslint-plugin-eslint-plugin). Updates `@typescript-eslint/eslint-plugin` from 7.0.2 to 7.1.0 Release notes Sourced from @​typescript-eslint/eslint-plugin's releases. v7.1.0 7.1.0 (2024-02-26) 🚀 Features eslint-plugin:...

dependabot[bot]

Currently this plugin pulls a big load of jsx-related dependencies to support the jsx rules, but these are useless dependencies for users who do not use jsx. How about splitting...

silverwind

Request: Add typescript support

1

I'm working on an addition to [insights-web](https://github.com/github/insights-web) ([PR](https://github.com/github/insights-web/pull/123)) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript `.d.ts` definitions for various exported types. This breaks the GitHub eslint...

kayla-glick

Force `es5` trailing commas

3

We should configure prettier to `es5` trailing commas. Why? makes diffs and reordering so much easier.

maraisr

Request: Include SSR-related rules

5

Would you consider adding SSR-related rules to the [recommended React config](https://github.com/github/eslint-plugin-github/blob/main/lib/configs/react.js) in the eslint ruleset? This would help catch SSR incompatibility during development instead of requiring more expensive remediation later.

lesliecdubs

```js window.addEventListener('click', click, { passive: false }); ``` This should trigger a `github/no-useless-passive` warning but doesn't.

boris-petrov