eslint-plugin-github icon indicating copy to clipboard operation
eslint-plugin-github copied to clipboard

Published 20 hours ago • verified publisher icon github

Force `es5` trailing commas

Open maraisr opened this issue 2 years ago • 3 comments

We should configure prettier to es5 trailing commas. Why? makes diffs and reordering so much easier.

maraisr avatar Oct 11 '22 02:10 maraisr

We've implemented this in github/github and are happy with the results. @maraisr do you think this would be worthy of a breaking change for this package if we made the change here?

dgreif avatar Jun 02 '23 03:06 dgreif

Hi @dgreif thank you for that. I also noticed we turned this setting to all within the prettier config. And yeah been super happy with the results. I think this is worthy of a breaking change yes.

maraisr avatar Jun 02 '23 03:06 maraisr

Thanks for pointing out the prettier change! Would you mind opening a PR for this? I'm happy to approve, as long as no one else on my team objects, and we can cut a breaking release

dgreif avatar Jun 02 '23 20:06 dgreif