hulk

Results 525 comments of hulk

I'm wondering if it'd be better to sacrifice the scope of the candidate set to simplify the implementation like below: 1. if size N, random among the first N elements...

> but where should we storing this and how do updating this? We're now using a LRU to cache the iterator key while scanning the DB/hash/set, maybe we can do...

> That's a bit complex 🤔, in my current impl I may just need to iter the set with one snapshot... Yes, it should be more complex than the current...

@mapleFU For Kvrocks, I feel good to only randomize part of them if there're too many keys.

@dim Sure, thank you! I will submit a PR for this.

@yliu634 感谢反馈,fatcache 已经停止维护,该项目也会归档掉

it seems good, I will try it out and merge later if didn't make performance ineffective too much. thanks for your great work.

@chronolaw @oowl @StarlightIbuki, is this PR good to merge?

@dndx @nowNick @ADD-SP @samugi Would you mind taking a look again?