hulk

Results 524 comments of hulk

Yes, I also think `StatusOr` is more intuitive than before

yup, it should be easy but we have no plan now

@mapleFU You're right that we only implemented RESP2 and have no plan to implement RESP3 recently. The main purpose of this command is to compatible with some Redis clients, which...

> > @mapleFU You're right that we only implemented RESP2 and have no plan to implement RESP3 recently. The main purpose of this command is to compatible with some Redis...

Good catch. I think the right behavior should return `ERR unknown command` on Kvrock's side, but unfortunately that Kvrocks will check the auth first now.

> @git-hulk I change the order in #830 and all tests look good. Thanks!

> You may give a report (sheet) for flaky tests, sorting out by categorizes. For example, tcl tests or unit tests. > > It should be helpful for anyone who...

@tisonkun I found most failures were caused by four tcl test cases,should we create issue for each one to track them?

> @git-hulk yes. We can create subtasks for them. Basically we create issue if someone volunteer to investigate (otherwise we create dangling issues), and it happens I'll give a look...