giomfo
giomfo
@florianjacob I would prefer to not consider this point here. This should be handled by another proposal.
This MSC has been implemented on mobile sdk level ([ios](https://github.com/matrix-org/matrix-ios-sdk/pull/959), [android](https://github.com/vector-im/element-android/pull/4753)) I would like to get it merged, but I'm concerned by the recent @kevincox comments on it. @turt2live, what...
@janogarcia thank you for your answer, don't you think we should update the other platforms (web/android) in order to hide the button on them too? If so, can you please...
See Text Programming Guide for iOS (https://developer.apple.com/library/ios/documentation/StringsTextFonts/Conceptual/TextAndWebiPhoneOS/CustomTextProcessing/CustomTextProcessing.html#//apple_ref/doc/uid/TP40009542-CH4-SW65)
@yostyle I observed a crash during my test I got it by filling a wrong matrix id (not an actual account)
In the empty room (temporary DM), the voice message is displayed in the text composer, but it seems disabled I would replace the placeholder with "Send your first message" to...
@yostyle I did some tests - the placeholder "Send your first message" is not reset after the DM creation (the `RoomInputToolbarViewSendMode` has to be updated) , all the points already mentioned during our first (@phlniji and I) reviews have been fixed. I will approve this PR, but we will...
@ismailgulek FYI I'm working with @phlniji to take into account your comment. We will ping you here when the PR will be ready for a new review
@ismailgulek FYI this PR has been updated, your review is requested on the [last commit](https://github.com/vector-im/element-ios/pull/6367/commits/ac1dda5645e794bd1e87c4c58d2cf44cd92aa7a8) of @phlniji which should fixed all your comments