Start DM on first message

[yostyle]

#5864

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov-commenter]

Codecov Report

Merging #6367 (aa1ec2d) into develop (33540c9) will increase coverage by 0.05%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6367      +/-   ##
===========================================
+ Coverage     6.13%    6.19%   +0.05%     
===========================================
  Files         1475     1476       +1     
  Lines       156165   156546     +381     
  Branches     62571    62735     +164     
===========================================
+ Hits          9577     9691     +114     
- Misses      146192   146451     +259     
- Partials       396      404       +8     

Impacted Files	Coverage Δ
Riot/Generated/Strings.swift	2.85% <0.00%> (-0.01%)	:arrow_down:
Riot/Modules/Application/LegacyAppDelegate.m	13.34% <0.00%> (+0.61%)	:arrow_up:
...on/ScreenNavigation/RoomNavigationParameters.swift	0.00% <0.00%> (ø)
...es/Contacts/Details/ContactDetailsViewController.m	0.00% <0.00%> (ø)
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift	0.00% <0.00%> (ø)
...dules/MatrixKit/Views/RoomTitle/MXKRoomTitleView.m	0.00% <0.00%> (ø)
...ules/Room/Members/RoomParticipantsViewController.m	0.00% <0.00%> (ø)
Riot/Modules/Room/RoomCoordinator.swift	0.00% <0.00%> (ø)
Riot/Modules/Room/RoomCoordinatorParameters.swift	0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m	0.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions[bot]]

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/miYLKi

[giomfo]

@yostyle I observed a crash during my test

I got it by filling a wrong matrix id (not an actual account)

[giomfo]

In the empty room (temporary DM), the voice message is displayed in the text composer, but it seems disabled

I would replace the placeholder with "Send your first message" to satisfy a minimum the requested design.

[giomfo]

@yostyle I did some tests

• the placeholder "Send your first message" is not reset after the DM creation (the RoomInputToolbarViewSendMode has to be updated)

• I created a second DM by sending a new message in this first one NOK

[yostyle]

@yostyle I did some tests

• the placeholder "Send your first message" is not reset after the DM creation (the RoomInputToolbarViewSendMode has to be updated)
• I created a second DM by sending a new message in this first one NOK

Fixed

[giomfo]

@ismailgulek Hi, except the following small remark, all the points already mentioned during our first (@phlniji and I) reviews have been fixed. I will approve this PR, but we will wait for your review before being able to merge it. Is that ok for you?

[ismailgulek]

@ismailgulek Hi, except the following small remark, all the points already mentioned during our first (@phlniji and I) reviews have been fixed.

I will approve this PR, but we will wait for your review before being able to merge it. Is that ok for you?

Yes, i'll provide a review when appropriate.

[giomfo]

@ismailgulek FYI I'm working with @phlniji to take into account your comment. We will ping you here when the PR will be ready for a new review

[giomfo]

@ismailgulek FYI this PR has been updated, your review is requested on the last commit of @phlniji which should fixed all your comments

[giomfo]

A final UX review based on build is planned before merging this PR

[giomfo]

During UX Review, we observed an issue: the selected attachment is ignored, it is not sent in the created DM

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information