Gino Miceli comments

Results 362 comments of


                                            Gino Miceli

trafficstars

[ACLs] Add custom text and link to sign up form

@lecrabe @rfontanarosa FYI

[ACLs] Add custom text and link to sign up form

> @gino-m Is the product requirement that first dialog be shown if the sign up form link is missing else the second dialog (as per [#2402 (comment)](https://github.com/google/ground-android/issues/2402#issuecomment-2113585224))? That's correct!

Added null check for Offline LOI

> Earlier app crash when any offline LOI is not available. Do you mean "when no LOIs are available offline"?

Added landscape support for Data Collection Dialog

@rawbzz wdyt?

Auto-rotate (landscape mode) doesn't work on many screens

@anandwana001 Can you please test rotation on all app screens and add UI tests for all screens.

Auto-rotate (landscape mode) doesn't work on many screens

Rotation is still not enabled, reopening.

Auto-rotate (landscape mode) doesn't work on many screens

@anandwana001 Confirmed all screens tested, closing.

Non-unique IDs for tasks in different jobs cause tasks to be overwritten in local DB

I propose the following solution long-term: - [ ] Serialize survey and jobs as protos in two tables in the local db, eliminating the Tasks table entirely. - [ ]...

Non-unique IDs for tasks in different jobs cause tasks to be overwritten in local DB

@scolsen Using protos everywhere is a much larger project. A patch is low priority here since this is a degenerate case which would only happen if someone accidentally manually adds...

Non-unique IDs for tasks in different jobs cause tasks to be overwritten in local DB

@scolsen @anandwana001 Can you confirm that tasks with the same ID in different jobs will no longer break the local db?