ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[ACLs] Add custom text and link to sign up form

Open gino-m opened this issue 1 year ago • 6 comments

For now we can add android:autoLink="web" to the dialog permission_denied_dialog.xml and customize the contact_survey_organizer_to_obtain_access string in the of-ground fork. In the future we should read the url from Firestore config/properties/signUpUrl @rfontanarosa FYI

See also https://github.com/google/ground-platform/issues/1679

gino-m avatar Mar 22 '24 10:03 gino-m

@gino-m or @jcqli is there a screenshot of what screen this would need to live? ty!

rawbzz avatar May 03 '24 17:05 rawbzz

@rawbzz There's currently a dialog which looks something like this (sorry for bad cropping):

image

Needs work!

gino-m avatar May 06 '24 09:05 gino-m

Something like this ? with a signup text link

Screenshot 2024-05-10 at 10 03 43 AM

rawbzz avatar May 10 '24 14:05 rawbzz

@rawbzz Much better! We should replace "Contact your system admin.." with the text explaining they don't have access and should sign up at the specified link. @amegantz for copy!

gino-m avatar May 13 '24 12:05 gino-m

image To continue, contact your system administrator to request access. To continue, sign up to request access.

If you sign out, all unsaved data will be lost.

amegantz avatar May 15 '24 22:05 amegantz

LGTM!

gino-m avatar May 16 '24 08:05 gino-m

@lecrabe @rfontanarosa FYI

gino-m avatar May 28 '24 12:05 gino-m

@shobhitagarwal1612 Do you have capacity to look work on this one?

jcqli avatar Jun 06 '24 16:06 jcqli

@gino-m Is the product requirement that first dialog be shown if the sign up form link is missing else the second dialog (as per https://github.com/google/ground-android/issues/2402#issuecomment-2113585224)?

shobhitagarwal1612 avatar Jun 10 '24 11:06 shobhitagarwal1612

@gino-m Is the product requirement that first dialog be shown if the sign up form link is missing else the second dialog (as per #2402 (comment))?

That's correct!

gino-m avatar Jun 10 '24 15:06 gino-m