ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

Added null check for Offline LOI

Open anandwana001 opened this issue 1 year ago • 3 comments

Fixes #2773

Earlier app crash when any offline LOI is not available. Added Null check of such LOI access logic

@shobhitagarwal1612 @sufyanAbbasi PTAL?

anandwana001 avatar Oct 10 '24 23:10 anandwana001

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base (c3ad147) to head (7819f36). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../android/ground/repository/SubmissionRepository.kt 0.00% 15 Missing :warning:
.../ground/repository/LocationOfInterestRepository.kt 37.50% 2 Missing and 3 partials :warning:
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 20.00% 4 Missing :warning:
...round/ui/datacollection/DataCollectionViewModel.kt 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2788      +/-   ##
============================================
- Coverage     61.96%   61.89%   -0.08%     
  Complexity     1166     1166              
============================================
  Files           265      265              
  Lines          6223     6235      +12     
  Branches        877      883       +6     
============================================
+ Hits           3856     3859       +3     
- Misses         1840     1847       +7     
- Partials        527      529       +2     
Files with missing lines Coverage Δ
...round/ui/datacollection/DataCollectionViewModel.kt 71.57% <75.00%> (-0.37%) :arrow_down:
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 45.45% <20.00%> (-7.18%) :arrow_down:
.../ground/repository/LocationOfInterestRepository.kt 50.87% <37.50%> (-0.11%) :arrow_down:
.../android/ground/repository/SubmissionRepository.kt 19.51% <0.00%> (-1.01%) :arrow_down:

codecov[bot] avatar Oct 11 '24 00:10 codecov[bot]

Earlier app crash when any offline LOI is not available.

Do you mean "when no LOIs are available offline"?

gino-m avatar Oct 11 '24 13:10 gino-m

@sufyanAbbasi to try to take a look at the PR approval in @gino-m 's absence

kenstershiro avatar Oct 23 '24 14:10 kenstershiro