Gino Miceli comments

Results 352 comments of


                                            Gino Miceli

trafficstars

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

Great, glad we're on the same page! tl;drs: 1. Ok to handle errors with onError*(), no need to wrap in value object. 1. With switchMapped streams, apply onErrorResumeNext() upstream (inside...

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

A few more thoughts while investigating adding consistent error handling: * Where do we report errors to the user? Ideally all user-visible logic should live in views, which implies we'd...

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

Snippet for wrapping/unwrapping mapped streams in `ValueOrError` objects: https://gist.github.com/gino-m/efcfd158a4d6e4461ac17a1a064d8a7e

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

> 2. With switchMapped streams, apply onErrorResumeNext() upstream (inside switchMap) where things can break; applying downstream is too late. I was just verifying this and I'm not convince this is...

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

Updated description to clarify what we need to verify.

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

@dturner Going through the code you may have noticed that we have inconsistent handling of error states, esp. wrt persistence. Some are propagated to the UI layer and handled there,...

[Code health] Verify exceptions are either wrapped or handled in all Rx streams

See also big refactor PR #371 for reference.

[Code health] Simplify applying window inset to components

Hi @shobhitagarwal1612 can we close this now?

[Data collection] First photo taken with camera doesn't appear

@shobhitagarwal1612 I didn't see anything relevant it the logs; no stack trace in Error log, no mentions of "camera" or "photo" at Verbose Tested with build at commit 675415446a7041ee6b45a32db87465b85a5c2a1d on...

[Data collection] First photo taken with camera doesn't appear

Confirmed there is an intent returned with the original request code, but the result code is 0 and the intent is null: For posterity, the interstitial dialog contents are: "Remember...