ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

Published 20 hours ago • verified publisher icon google

[Code health] Simplify applying window inset to components

Open shobhitagarwal1612 opened this issue 5 years ago • 3 comments
trafficstars

The main activity subscribes to window inset changes and all fragments listen to that and apply padding/margin/translationY to adjust themselves accordingly.

A lot of code, dedicated for this purpose can be replaced with tuning the xmls directly by separating the components that need adjustment from rest and setting fitsSystemWindows to true

shobhitagarwal1612 avatar May 24 '20 07:05 shobhitagarwal1612

Hi @shobhitagarwal1612 can we close this now?

gino-m avatar Jul 13 '20 22:07 gino-m

One or two instances are still remaining. See the linked PR for details

shobhitagarwal1612 avatar Jul 14 '20 04:07 shobhitagarwal1612

HomeScreenFragment and FeatureDetailsFragment could also use similar refactoring.

shobhitagarwal1612 avatar Jul 14 '20 05:07 shobhitagarwal1612

Closing this as obsolete.

shobhitagarwal1612 avatar Apr 11 '24 13:04 shobhitagarwal1612