Dale McDiarmid
Dale McDiarmid
Ok i can reproduce this. Before i start #623 id like to understand why its soo bad.
https://github.com/ClickHouse/clickhouse-go/pull/646 doesnt provide any reasonable improvement. We need to see how much of this is in ch-go @ernado
Ok lets move this issue to ch-go once https://github.com/ClickHouse/clickhouse-go/pull/646 is merged.
Using ``` func TestRead(b *testing.T) { conn := getConnection() start := time.Now() rows, err := conn.Query(context.Background(), fmt.Sprintf(`SELECT toString(number) FROM numbers(500000000)`)) if err != nil { b.Fatal(err) } var ( col1...
fail-fast invariably will slow down inserts - the client will need to parse the data twice. We could make this a switch to disable?
@ernado @mshustov note i've added issue (2).Shoud failure to append to a batch invalidate the batch?
@fiftin we need to go through and compare v1 and v2 to see where type conversions are missing that also don't loose precision. Then we need to address gaps. Right...
No im sure there are more cases we have gaps, I just haven't done a complete audit.
Currently supported conversions now documented [here](https://github.com/ClickHouse/clickhouse-go/blob/examples/TYPES.md). This will be merged to main. We welcome PRs to add `X`'s.
@DGuang21 if we support text im hesitant to support anything other than the [default format supported](https://clickhouse.com/docs/en/interfaces/formats/#tabseparated-data-formatting) by ClickHouse. Maybe we could consider https://clickhouse.com/docs/en/operations/settings/settings/#date_time_input_format but I'm not sure I want to...