Dale McDiarmid
Dale McDiarmid
Good spot, agree this needs to be done.
should be doable by simply passing a compressor into the Encode method. We can then compress each column as we encode it.
I want to make this change i'm cautious re the potential performance impact. Ill raise a PR and do some tests.
BRanch here with these changes https://github.com/ClickHouse/clickhouse-go/tree/compress_by_column but I'm not happy with implementation
Thanks @zdyj3170101136 this feels alittle tightly coupled. Have you considered using https://github.com/qustavo/sqlhooks ? e.g. https://github.com/DataDog/dd-trace-go/blob/main/contrib/go-pg/pg.v10/pg_go.go#L28
Unlikely we will merge this in its current form as its quite intrusive. @genzgd for 2nd opinion.
@mshustov this is something for which we should be consistent across clients It makes more sense to me for local query settings to override connection-level settings - its been the...
`.WithProtectedSettings()` makes the most sense to me. `.WithSettingsOverride()` is confusing - it just means query level settings are ignored or would the intention for this to be applied at the...
Ok but for your original use case `.WithProtectedSettings()` would resolve the issue. Those settings pertaining to row security would be applied here (you should really use CH inbuilt row security...
Open to accepting a PR for this as I think it makes sense. Otherwise it will likely not make it till December timeframe.