Dale McDiarmid

Results 194 comments of Dale McDiarmid

that needs reflection again, costly and no better than (1), which would be a similar cost I suspect (need to test) at no real gain.

A wont type check to int8. Using the annotation is supported in JSON. If you want to support that in normal appendstruct its a different feature request.

Agreed the coupling is annoying. This feels like a v3 feature but we might be able to achieve the behavior by allowing the connection to be reassigned after `Send()` -...

Also, over http we make a DESCRIBE call on prepareBatch. Reusable batches would avoid this overhead.

@ns-gzhang im not clear how the connection can be reused since on cancel we don't release it. Re https://github.com/ClickHouse/clickhouse-go/issues/727#issuecomment-1239665912 The connection is not released back into the idle pool since...

Ok release is called when the deadline is exceeded but its not pushing it back into the pool because of ``` if err != nil || time.Since(conn.connectedAt) >= ch.opt.ConnMaxLifetime {...

Same test using std interface and OpenDB - connection is successfully marked as Bad since its a timeout. ![image](https://user-images.githubusercontent.com/12695796/192140286-76284333-f970-4fc3-a7bf-d93a5c16102a.png) @ns-gzhang how are the timeouts occurring? I'm using context so maybe...

Are you possibly sharing the same context across two queries...i could possibly see how that could cause an issue on cancel. Specifically: 1. query q1 is cancelled on timeout. It...

@ns-gzhang i dont think its reuse of a context - the client guards against this. I'm going to put up a branch that closes the connection on cancel. Can you...

@ns-gzhang can you test https://github.com/ClickHouse/clickhouse-go/pull/764 and see if it runs without error? If it does, we will merge.