clickhouse-go icon indicating copy to clipboard operation
clickhouse-go copied to clipboard

support opentelemetry

Open zdyj3170101136 opened this issue 2 years ago • 1 comments

the clickhouse supported opentelemetry: https://clickhouse.com/docs/en/operations/opentelemetry/

so i think the driver should support otel.

zdyj3170101136 avatar Sep 30 '22 08:09 zdyj3170101136

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


杨杰 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 30 '22 08:09 CLAassistant

Thanks @zdyj3170101136 this feels alittle tightly coupled. Have you considered using https://github.com/qustavo/sqlhooks ? e.g. https://github.com/DataDog/dd-trace-go/blob/main/contrib/go-pg/pg.v10/pg_go.go#L28

gingerwizard avatar Oct 26 '22 09:10 gingerwizard

Unlikely we will merge this in its current form as its quite intrusive. @genzgd for 2nd opinion.

gingerwizard avatar Nov 01 '22 10:11 gingerwizard

Closing due to stale changes. I recommend hooking on a database/sql interface level.

jkaflik avatar Dec 09 '22 14:12 jkaflik